Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific effects changing type when older modules are saved in 0.5.0.0 #184

Closed
Threxx11 opened this issue Jan 18, 2023 · 1 comment · Fixed by #195
Closed

Specific effects changing type when older modules are saved in 0.5.0.0 #184

Threxx11 opened this issue Jan 18, 2023 · 1 comment · Fixed by #195

Comments

@Threxx11
Copy link

Threxx11 commented Jan 18, 2023

Transferring my post in the famitracker.org discord...

okay, this is pretty consistently reproducible
if you make a module with a Txy effect, save the module, and reopen it, the Txy effects in the module will all be changed to Ixx effects. as you can imagine this can severely break modules reliant on the transpose effect and is not ideal.

the steps i took to reproduce it:

  1. make a new module. i tested forward porting modules from 0CC and new modules made in Dn, it seems to occur no matter what
  2. add a Txy effect to any channel.
  3. save the module
  4. close the tracker, and then reopen the same module. the effects will now be changed to the wrong type as stated previously.

It also seems that other effects may also transform when the module is updated, though I have not observed these directly myself, I will note them:
-0xx effects may be replaced with Hxx effects when a module is saved and loaded.
-Lxx effects may be replaced with Wxx effects when a module is saved and loaded, but only on the DPCM channel.

Attached are 3 modules demonstrating the Txy effect replacement phenomena.
test.zip

Gumball2415 added a commit that referenced this issue Mar 3, 2023
@Gumball2415 Gumball2415 reopened this Mar 10, 2023
@Gumball2415 Gumball2415 linked a pull request Mar 10, 2023 that will close this issue
Gumball2415 added a commit that referenced this issue Mar 12, 2023
@Gumball2415
Copy link
Collaborator

what version are these test modules saved in?

Gumball2415 added a commit that referenced this issue Mar 26, 2023
Gumball2415 added a commit that referenced this issue Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants