Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardware sweep (Hxx + Ixx) and envelope (EEx) not working together in NSF export #297

Closed
badgertapes opened this issue Sep 19, 2024 · 4 comments · Fixed by #262
Closed

Hardware sweep (Hxx + Ixx) and envelope (EEx) not working together in NSF export #297

badgertapes opened this issue Sep 19, 2024 · 4 comments · Fixed by #262
Labels
bug Something isn't working nsf-driver sound engine used in NSF/assembly file export

Comments

@badgertapes
Copy link

When Hardware sweeps are combined with Hardware envelopes, they play back correctly within Dn-FamiTracker and through its WAV export. However, through NSF export, all envelopes when combined with sweeps are cut off to the same length. Attached are two wave files, going through all the envelopes through both WAV and NSF export.

I have not tested any other exports to confirm if this happens with the other available file types.

env + sweep WAV output (.wav file)
env + sweep NSF output (.wav file)
@Gumball2415
Copy link
Collaborator

can you send the relevant test module files?

@badgertapes
Copy link
Author

hwenv.dnf (Dn-Famitracker 0.5.0.2)
hwenv.nsf

@Gumball2415
Copy link
Collaborator

thank you
what version of Dn-FT are you using?

@badgertapes
Copy link
Author

Version 0.5.0.2

@eulyderg eulyderg added the bug Something isn't working label Nov 17, 2024
@Gumball2415 Gumball2415 added the nsf-driver sound engine used in NSF/assembly file export label Nov 23, 2024
Gumball2415 added a commit that referenced this issue Dec 25, 2024
@Gumball2415
Write length counter load when writing pitch
2106d58 
Fixes #297.
@Gumball2415 Gumball2415 mentioned this issue Dec 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working nsf-driver sound engine used in NSF/assembly file export
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NSF Driver and Export Fixes Dn-Programming-Core-Management/Dn-FamiTracker
3 participants
@badgertapes @eulyderg @Gumball2415