New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when writing to WAV (channel export?) #92

Closed

nyanpasu64 opened this issue Oct 12, 2021 · 1 comment · Fixed by #93

Collaborator

nyanpasu64 commented Oct 12, 2021

bool CSoundGen::PlayBuffer() calls m_pWaveFile->WriteWave(m_pAccumBuffer, m_iBufSizeBytes) when m_pWaveFile is nullptr.

I wonder if m_bRendering is written/seen before m_pWaveFile due to a data race.

The text was updated successfully, but these errors were encountered:

Collaborator Author

nyanpasu64 commented Oct 12, 2021 •

edited

Loading

it's a classic data race.

audio:

gui:

Channel export end: CWavProgressDlg::OnTimer():
- - = false
Next channel export begin: CWavProgressDlg::OnInitDialog():
- CSoundGen::RenderToFile()
  - m_pWaveFile has not been reset yet.

audio: CSoundGen::PlayBuffer():

- m_pWaveFile has since been reset.

rewrite it in rust.

nyanpasu64 mentioned this issue

Fix random crash when exporting channels as WAV #93

Merged

Gumball2415 closed this as completed in #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment