Fix random crash when exporting channels as WAV #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CWavProgressDlg::OnInitDialog() is modified to start a timer with a 0 millisecond period, then sometimes CWavProgressDlg::OnTimer() will run before the render starts (CSoundGen::OnStartRender() is called). The dialog calls CSoundGen::IsRendering() which returns false, and then closes and initiates the next render, skipping the current one (and leaving the file handle open). This commit makes CSoundGen::IsRendering() return true before the render starts, so the dialog properly waits for the render to finish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this code is approximately correct. I've tested it with
CWavProgressDlg's timer set to run continuously (switch 200 to 0), and it seems to work without issues.This code fixes the random crash when exporting multiple channels (due to a data race/race condition), and a theoretical issue that causes WAV files to be skipped entirely if the GUI dialog's progress bar timer fires before the audio thread gets a chance to start rendering (which is unlikely to happen unless the timer is modified to run continuously, as mentioned above).
Fixes #92.