Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target volume slide effect (Nxy) #109

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

ipidev
Copy link
Contributor

@ipidev ipidev commented Dec 2, 2021

Implemented a target volume slide effect as Nxy, x = speed, y = target volume. The NSF drivers have been updated accordingly.

I designed it to be a volume-equivalent of the portamento effects Qxy/Rxy (which means I guess you also could consider Axy the volume-equivalent of 1xx/2xx). This means that the effect stops once the target volume is reached, or if the volume is set to a different value. The effect is also mutually exclusive with Axy as they both modify the channel volume.

I've tested both the tracker and NSF export for all channels that support the channel volume.

@nyanpasu64
Copy link
Collaborator

This is unrelated to whether this PR gets accepted or not, but personally I'm interested in adding duration-target effects for volume, pitch, and portamento, rather than slope-duration/target. Either this would be a separate effect from the existing ones, or replace the existing slope or slope-target effects in modules with a new setting enabled. Is that type of effect viable to implement in the NSF driver, and if so can you open a separate PR for that?

@ipidev
Copy link
Contributor Author

ipidev commented Dec 2, 2021

There's no really good way to do that in 1) a way that fits into a single byte parameter, 2) is intuitive to use, and 3) works for consistently for all effects. Any solution would be really cumbersome to implement without rewriting large parts of the driver.

…ide target is reached, matching behaviour in the tracker
@Gumball2415 Gumball2415 merged commit 507142d into Dn-Programming-Core-Management:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants