Register view improvements #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Arrange register layout to 4 bytes per row - Add modulation pitch and depth - Arrange waveform view
- Placed "rate" instead of pitch when sample rate is measured instead - Justify and align frequency hertz text
- Put misc. GUI settings into its own config tab - Fix warning being treated as error for x86 builds - Put misc. GUI settings into its own settings category and registry
Even with this fix, both the oscilloscope and spectrum visualizer rely on the visualizer thread processing incoming data faster than the audio thread can write new data, on a "best-effort" basis. If the visualizer falls behind, the oscilloscope or spectrum will show a discontinuity in incoming data. The discontinuity will appear at a random point of the oscilloscope. In spectrum mode, it will affect the entire spectrum, but only appears at buffer lengths below 2048 samples.
- Arrange register layout to 4 bytes per row - Add modulation pitch and depth - Arrange waveform view
- Placed "rate" instead of pitch when sample rate is measured instead - Justify and align frequency hertz text
- Put misc. GUI settings into its own config tab - Fix warning being treated as error for x86 builds - Put misc. GUI settings into its own settings category and registry
nyanpasu64
reviewed
Apr 19, 2022
Source/PatternEditor.cpp
Outdated
| text.Format(_T("%s, %s, size = %i byte%c"), GetPitchTextFunc(1, period & 0x0F, freq), | ||
| (reg[0] & 0x40) ? _T("looped") : _T("once"), (reg[3] << 4) | 1, reg[3] ? 's' : ' '); | ||
| vol = 15 *!pSoundGen->PreviewDone(); | ||
| text.Format(_T("%s, %-5s size = %-4i byte%c"), GetPitchTextFuncLong(1, (period & 0x0F), freq, 1), |
There was a problem hiding this comment.
It would be cool if, in DPCM mode, sufficiently short looped samples had their periodicities plotted. Not sure if this will suffer from wrong frequencies so often it's useless in practice. For example, https://www.youtube.com/watch?v=v-gdIjKd7Ic has a looped sample of a high note, but the loop length is like 17 wave periods long or something, so the register viewer shows a period 4 octaves down at the wrong note, and every DPCM sample has a differently wrong loop length.
Will a DPCM pitch viewer be right or wrong more often, or not show up at all in nearly all modules?
…gramming-Core-Management/Dn-FamiTracker into feature-FDS-register-view
Does not change name in registry!
- Add wavetable register view - Add modulation register data - Add output modulation pitch in volume row
- Use a filled wide rectangle instead of an extra colored rectangle - Get output frequency directly from FDS emulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.