Fix crash when starting program with pattern editor off-screen #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanpasu64
force-pushed
the
fix-offscreen-crash
branch
from
b677798 to
741b512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If FamiTracker is closed when (on Windows 10) offscreen or (on Windows 7) too small, and the pattern editor is not visible the next time you launch it, CFamiTrackerView::OnEraseBkgnd() fails to call CPatternEditor::CreateBackground(). This calls CPatternEditor::CreateBackground() from CPatternEditor::DrawScreen() if CPatternEditor's pDC pointers are null.
Calling CPatternEditor::CreateBackground() is necessary both to initialize the various pDCs for CPatternEditor::DrawScreen(), and because it calls CPatternEditor::CalculatePatternLayout(), which is needed for the frame editor to scroll with playback.
This is a hack, but it seems to work and I don't know any better ways to fix it (and I don't fully understand the legacy MFC architecture).
Fixes #128.