Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct paths on case-sensitive filesystems #18

Merged

Conversation

nyanpasu64
Copy link
Collaborator

On Windows 10 with WSL enabled, you can enable NTFS case sensitivity through fsutil.exe file SetCaseSensitiveInfo [folder] enable. This causes Git (both Windows and WSL) and compilers to malfunction, and is very difficult to fix. But Git on Windows (case-insensitive by default) encounters breakage as well, just less often.

This PR fixes the consistency of upper/lowercase folders, files, and references to them in C++ #include, Visual Studio .vcxproj[.filters], and CMake files. I verified that compilation works in CMake, but didn't fully verify in Visual Studio, where IntelliSense is broken with case sensitivity enabled (wrecking the user experience).

This PR should have no effects; it does not enable NTFS case sensitivity, you have to do it yourself.

Based on a diff by @Gumball2415.

On Windows 10 with WSL enabled, you can enable NTFS case sensitivity
through `fsutil.exe file SetCaseSensitiveInfo [folder] enable`.
This causes Git (both Windows and WSL) and compilers to malfunction,
and is very difficult to fix.
But Git on Windows (case-insensitive by default) encounters breakage
as well, just less often.
@Gumball2415 Gumball2415 merged commit 276376f into Dn-Programming-Core-Management:master Dec 18, 2020
@nyanpasu64 nyanpasu64 deleted the fix-file-case branch January 27, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants