Fix outputting audio to multi-channel output devices #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes opening multi-channel output devices.
An exception didn't follow the existing pattern of error handling (bad), and would terminate the program (bad). Unfortunately std::runtime_error currently closes the program without showing a message to the user; this should be fixed at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to add support for multi-channel audio devices which would previously fail to open.
Tested to play audio properly on Windows 11 with mono, stereo, and surround audio devices (outputs to first 2 channels). Tested to play sound on stereo speakers on Wine on PipeWire.
Changes in this PR: