Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register viewer adjustments #338

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Register viewer adjustments #338

wants to merge 6 commits into from

Conversation

Gumball2415
Copy link
Collaborator

@Gumball2415 Gumball2415 commented Mar 6, 2025

This pull request aims to adjust tracker register view and refactor related code.

Changes in this PR:

  • Refactor and adjust tracker register view
    • Refactor pitch, volume, and note drawing functions
    • Apply OETF gamma 2.2 for viewing low volume values
    • Reduce magic constants in source
    • Add tone tints for 5B, FDS, and 2A03 periodic noise
    • Implement pitched 2A03 periodic noise pitch-volume indicator
    • Implement logarithmic level for VRC7 pitch-volume indicator

- Add equivalent note for periodic noise
- Apply OETF gamma 2.2 for viewing low volumes
- Set OETF gamma function as lambda
- Refactor precise pitch selection
- Add tone tint for S5B notes
- S5B volume 0 does not output anything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant