New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSF FDS fixes #341

Open

Gumball2415 wants to merge 2 commits into main from nsf-fds-mod

Collaborator

Gumball2415 commented Mar 11, 2025

This pull request aims to synchronize effect bytecode ordering and fix FDS modulation.

Changes in this PR:

Refactor FDS modulation implementation in NSF driver
Synchronize effect bytecode order when compiling "glob" multichip
- Fixes issue Effect command bytecode offset desync when exporting to .asm #331

Gumball2415 added 2 commits

January 25, 2025 01:06


          NSF Driver: save ModFreq before comparison

e558f6b

Thanks, @eightbitmays.bsky.social!

- Define FDS effects as an enum


          NSF Driver: include "glob" logic in effect command

a9202e0

This fixes #331.

Gumball2415 changed the title ~~Nsf fds mod~~ NSF FDS fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet