VRC7 instrument editor fixes and features #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a textbox next to the combo box that shows the current VRC7 patch in realtime. The format is the same as in the copy/paste buttons. Patch editing within the textbox is not yet implemented.
Before the emulator core update, the VRC7 hardware patches were stored in a 1D byte array, where each patch is followed by eight 0x00 bytes. The instrument editor code compensates for the extra eight bytes by skipping over them. Since the VRC7 emulator core update, the hardware patch header file is now replaced by multiple ones that are part of NSFPlay's emu2413. However, the new hardware patch header files don't have the extra eight bytes, so the instrument editor skips over every other patch instead. To fix this, the code used to extract individual patches out of the array has been modified to not skip over every other eight bytes. This fixes issue #50.
This adds the following editing funtionality for the patch textbox in the VRC7 instrument editor: - The textbox modifies the instrument patch when you press enter. - The textbox automatically updates whenever you modify the sliders. - Upon pressing enter while selecting a hardware patch, it copies the current patch to patch 0 and switches to it.
With the addition of YM2413 and YMF281B patches, the instrument names and patch bytes within the instrument editor now change based on the hardware patch bank selected.
nyanpasu64
requested changes
Jun 16, 2021
Gumball2415
force-pushed
the
vrc7-inst-editor-feature
branch
from
f1f111c to
a10aad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.