Fix volume levels of N163 and 5B to match previous 0CC/Dn #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The N163/5B's volume levels changed in 0df4d72 (Dn-Programming-Core-Management#27). When moving chip volume levels from CMixer's declaration to CMixer::UpdateSettings(), I swapped their levels by mistake. (This happened because SynthS5B and SynthN163 were listed in opposite orders in the declaration and method.) This resulted in the 5B being too quiet and N163 being too loud, compared to past versions of 0CC/Dn. This commit fixes their volume levels to match prior program versions. Both the N163 and 5B volume level formulas are probably inaccurate, but at least matching prior versions of FT is better than being inconsistent.
nyanpasu64
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The N163/5B's volume levels were unintentionally changed in #27, which sadly made it into the 0.3.0 release.
When moving chip volume levels from CMixer's declaration to
CMixer::UpdateSettings(), I swapped their levels by mistake. (This happened becauseSynthS5BandSynthN163were listed in opposite orders in the declaration and method.) This resulted in the 5B being too quiet and N163 being too loud, compared to past versions of 0CC/Dn.This PR fixes their volume levels to match prior program versions. Both the N163 and 5B volume level formulas are probably inaccurate, but at least matching prior versions of FT is better than being inconsistent.