Merge pull request #405 from DrTimothyAldenDavis/v10.0.branch

GraphBLAS 10.0.1
DrTimothyAldenDavis · Mar 5, 2025 · e0fb970 · e0fb970
2 parents a2e3efd + a2c7521
commit e0fb970
Show file tree

Hide file tree

Showing 891 changed files with 2,125 additions and 3,836 deletions.
diff --git a/Doc/ChangeLog b/Doc/ChangeLog
@@ -1,3 +1,8 @@
+Mar 6, 2025: version 10.0.1
+
+    * (60) bug fix: one of the GrB_mxm kernels (saxpy4) can hit a segfault for
+        user-defined types, in the JIT kernels.  Caught by Gabe Gomez.
+
 Mar 1, 2025: version 10.0.0
 
     * 32/64 bit matrices and vectors: the GrB_Matrix and GrB_Vector

diff --git a/Doc/GraphBLAS_UserGuide.pdf b/Doc/GraphBLAS_UserGuide.pdf
diff --git a/Doc/GraphBLAS_version.tex b/Doc/GraphBLAS_version.tex
@@ -1,5 +1,5 @@
 % version of SuiteSparse:GraphBLAS
 \date{VERSION
-10.0.0,
-Mar 3, 2025}
+10.0.1,
+Mar 6, 2025}
 
diff --git a/Doc/UserGuide/GrB_release.tex b/Doc/UserGuide/GrB_release.tex
@@ -5,6 +5,13 @@ \section{Release Notes}
 
 \begin{itemize}
 
+\item Mar 6, 2025: version 10.0.1
+
+    \begin{itemize}
+    \item (60) bug fix: one of the \verb'GrB_mxm' kernels (saxpy4) can hit a
+    segfault for user-defined types, in the JIT kernels.  Caught by Gabe Gomez.
+    \end{itemize}
+
 \item Mar 1, 2025: version 10.0.0
 
     \begin{itemize}

diff --git a/FactoryKernels/GB_AxB__band_band_uint16.c b/FactoryKernels/GB_AxB__band_band_uint16.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_band_uint16)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_band_uint32.c b/FactoryKernels/GB_AxB__band_band_uint32.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_band_uint32)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_band_uint64.c b/FactoryKernels/GB_AxB__band_band_uint64.c
@@ -204,8 +204,7 @@ GrB_Info GB (_Asaxpy4B__band_band_uint64)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_band_uint8.c b/FactoryKernels/GB_AxB__band_band_uint8.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_band_uint8)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bor_uint16.c b/FactoryKernels/GB_AxB__band_bor_uint16.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_bor_uint16)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bor_uint32.c b/FactoryKernels/GB_AxB__band_bor_uint32.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_bor_uint32)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bor_uint64.c b/FactoryKernels/GB_AxB__band_bor_uint64.c
@@ -204,8 +204,7 @@ GrB_Info GB (_Asaxpy4B__band_bor_uint64)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bor_uint8.c b/FactoryKernels/GB_AxB__band_bor_uint8.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_bor_uint8)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bxnor_uint16.c b/FactoryKernels/GB_AxB__band_bxnor_uint16.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_bxnor_uint16)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bxnor_uint32.c b/FactoryKernels/GB_AxB__band_bxnor_uint32.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_bxnor_uint32)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bxnor_uint64.c b/FactoryKernels/GB_AxB__band_bxnor_uint64.c
@@ -204,8 +204,7 @@ GrB_Info GB (_Asaxpy4B__band_bxnor_uint64)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bxnor_uint8.c b/FactoryKernels/GB_AxB__band_bxnor_uint8.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_bxnor_uint8)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bxor_uint16.c b/FactoryKernels/GB_AxB__band_bxor_uint16.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_bxor_uint16)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bxor_uint32.c b/FactoryKernels/GB_AxB__band_bxor_uint32.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_bxor_uint32)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bxor_uint64.c b/FactoryKernels/GB_AxB__band_bxor_uint64.c
@@ -204,8 +204,7 @@ GrB_Info GB (_Asaxpy4B__band_bxor_uint64)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__band_bxor_uint8.c b/FactoryKernels/GB_AxB__band_bxor_uint8.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__band_bxor_uint8)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_band_uint16.c b/FactoryKernels/GB_AxB__bor_band_uint16.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_band_uint16)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_band_uint32.c b/FactoryKernels/GB_AxB__bor_band_uint32.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_band_uint32)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_band_uint64.c b/FactoryKernels/GB_AxB__bor_band_uint64.c
@@ -204,8 +204,7 @@ GrB_Info GB (_Asaxpy4B__bor_band_uint64)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_band_uint8.c b/FactoryKernels/GB_AxB__bor_band_uint8.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_band_uint8)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bor_uint16.c b/FactoryKernels/GB_AxB__bor_bor_uint16.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_bor_uint16)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bor_uint32.c b/FactoryKernels/GB_AxB__bor_bor_uint32.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_bor_uint32)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bor_uint64.c b/FactoryKernels/GB_AxB__bor_bor_uint64.c
@@ -204,8 +204,7 @@ GrB_Info GB (_Asaxpy4B__bor_bor_uint64)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bor_uint8.c b/FactoryKernels/GB_AxB__bor_bor_uint8.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_bor_uint8)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bxnor_uint16.c b/FactoryKernels/GB_AxB__bor_bxnor_uint16.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_bxnor_uint16)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bxnor_uint32.c b/FactoryKernels/GB_AxB__bor_bxnor_uint32.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_bxnor_uint32)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bxnor_uint64.c b/FactoryKernels/GB_AxB__bor_bxnor_uint64.c
@@ -204,8 +204,7 @@ GrB_Info GB (_Asaxpy4B__bor_bxnor_uint64)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bxnor_uint8.c b/FactoryKernels/GB_AxB__bor_bxnor_uint8.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_bxnor_uint8)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bxor_uint16.c b/FactoryKernels/GB_AxB__bor_bxor_uint16.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_bxor_uint16)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bxor_uint32.c b/FactoryKernels/GB_AxB__bor_bxor_uint32.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_bxor_uint32)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bxor_uint64.c b/FactoryKernels/GB_AxB__bor_bxor_uint64.c
@@ -204,8 +204,7 @@ GrB_Info GB (_Asaxpy4B__bor_bxor_uint64)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bor_bxor_uint8.c b/FactoryKernels/GB_AxB__bor_bxor_uint8.c
@@ -203,8 +203,7 @@ GrB_Info GB (_Asaxpy4B__bor_bxor_uint8)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bxnor_band_uint16.c b/FactoryKernels/GB_AxB__bxnor_band_uint16.c
@@ -197,8 +197,7 @@ GrB_Info GB (_Asaxpy4B__bxnor_band_uint16)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bxnor_band_uint32.c b/FactoryKernels/GB_AxB__bxnor_band_uint32.c
@@ -197,8 +197,7 @@ GrB_Info GB (_Asaxpy4B__bxnor_band_uint32)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bxnor_band_uint64.c b/FactoryKernels/GB_AxB__bxnor_band_uint64.c
@@ -199,8 +199,7 @@ GrB_Info GB (_Asaxpy4B__bxnor_band_uint64)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE

diff --git a/FactoryKernels/GB_AxB__bxnor_band_uint8.c b/FactoryKernels/GB_AxB__bxnor_band_uint8.c
@@ -197,8 +197,7 @@ GrB_Info GB (_Asaxpy4B__bxnor_band_uint8)
     const bool use_atomics,
     const int64_t *A_slice,
     const int64_t *H_slice,
-    GB_void *restrict Wcx,
-    int8_t *restrict Wf
+    GB_void *restrict Wcx
 )
 { 
     #if GB_DISABLE