Conditionally Couple Wave Fields based on COMPSET #6885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinethomas
requested review from
liho745,
sbrus89 and
jonbob
and removed request for
liho745
erinethomas
changed the title
erinethomas
force-pushed
the
ww3/conditional_wave_cpl_hist_fields
branch
from
decae62 to
6acbf9e
Compare
|
@erinethomas <https://github.com/erinethomas> not sure whether there has
been some confusion -- I work on the river component and don't know much
about wave or ocean.
…On Thu, Jan 9, 2025 at 5:06 PM Erin E Thomas ***@***.***> wrote:
@erinethomas <https://github.com/erinethomas> requested your review on:
#6885 <#6885> Wave Fields are
CONDITIONALLY coupled based on COMPSET.
—
Reply to this email directly, view it on GitHub
<#6885 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5QWBWDCXRWZZEUAFZJN7D2J36JBAVCNFSM6AAAAABU5GA3SKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHA3TINRYGA2TMMI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Closed
erinethomas
force-pushed
the
ww3/conditional_wave_cpl_hist_fields
branch
from
6acbf9e to
ba5f2ff
Compare
|
@erinethomas would it be hard to change "one" to "oneway" and "two" to "twoway"? I feel like being more descriptive is worth it. |
|
@rljacob - that is a good suggestion - I'll do that now. |
rljacob
approved these changes
Feb 17, 2025
|
@jonbob please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a issue in E3SM where the coupler history files contain wave variables even in compsets with NO active wave component. This PR fixes the issue by making all coupled wave fields "conditional" on the existence of an active wave component.
This PR produces BFB results in standard B cases with no active waves apart from the differing field list.
This PR adds a drv_in namelist variable called "wav_ocn_coup". This variable controls the coupling between the wave and ocean components. "wav_ocn_coup" is automatically defined (no user input is required) with one of the following: "none", "oneway" or "twoway" - based on the active components in the selected COMPSET.
For example, a B case with active WW3 automatically sets the wav_ocn_coup to "twoway" (full two-way coupling enabled between waves and ocean). However, a standard B case with no WW3 sets "wav_ocn_coup to "none" where no wave-ocean coupling is defined in the model.
Note: This framework is flexible enough to allow future capabilities of wave coupling. For example, in compsets where a data ocean model is used, wav_ocn_coup could be set to "oneway", to enable one way coupling (passing information from a data ocean model to active wave component). Furthermore, this framework will be expanded upon in the future to allow one and two way coupling between wave-atmosphere, as well as wave-sea ice components.
[NML]
[non-BFB] -- fieldlist-only