Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fates parameter file to API 37.1 #7027

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

glemieux
Copy link
Contributor

This simple PR updates the default fates parameter file as well as the fates tag.

This parameter file should be coordinated with NGEET/fates#1334.

This PR should also precede #6918.

[non-B4B] for FATES tests only

@glemieux glemieux marked this pull request as ready for review February 18, 2025 23:31
@glemieux glemieux requested a review from rgknox February 18, 2025 23:32
@bishtgautam bishtgautam self-assigned this Feb 20, 2025
Copy link
Contributor

@bishtgautam bishtgautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glemieux
Copy link
Contributor Author

The new parameter file is missing from https://web.lcrc.anl.gov/public/e3sm/inputdata/lnd/clm2/paramdata/

Thanks for the reminder @bishtgautam. I just loaded it.

@bishtgautam
Copy link
Contributor

The file was copied to Chrysalis' local inputdata dir, but not to the e3sm's public inputdata dir (/lcrc/group/acme/public_html/inputdata). I have copied the file to the public data dir.

@bishtgautam
Copy link
Contributor

@rgknox, @glemieux, Is this ready to go?

@glemieux
Copy link
Contributor Author

glemieux commented Mar 7, 2025 via email

@glemieux glemieux force-pushed the lnd/fates-api37.1 branch from 0aa7a8d to 3c8963b Compare March 8, 2025 23:14
@glemieux
Copy link
Contributor Author

glemieux commented Mar 10, 2025

Regression testing on perlmutter against the master baseline is showing expected diffs for the fates testmods, but there are two tests that are unexpectedly failing RUN due to mass balance errors that I'm tracking down. These are failing both for the intel and gnu versions of the same tests:

    FAIL SMS_D_Ld20.f45_f45.IELMFATES.pm-cpu_gnu.elm-fates_rd RUN time=38
    FAIL SMS_Ld20.f45_f45.IELMFATES.pm-cpu_gnu.elm-fates_eca RUN time=46

The run is failing 3 days into the test. The error value is consistant across the compiler type.

Results: /global/homes/g/glemieux/scratch/e3sm-tests/pr7027-eld.fates.pm-cpu..E3c8963b2ed-Fccc1de04

@glemieux
Copy link
Contributor Author

glemieux commented Mar 10, 2025

This issue above appears to be due to an earlier fates tag sci.1.80.0_api.37.0.0 in which the growth respiration was moved to the daily timestep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants