Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

信頼性向上のための処理を追加 #1201

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nanasess
Copy link
Contributor

脆弱性ではないが、チェックの甘い箇所を修正

  • 画像の filepath にエスケープ処理を追加
  • 受注編集画面の order_id にバリデーションを追加

- 未定義や空文字列、nullの場合は通す
- 数値または文字列の 0 の場合は通す
- 整数の場合は通す
- 数値以外の文字列の場合は trigger_error をコールする
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.61%. Comparing base (9a22b40) to head (be30e63).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1201   +/-   ##
=======================================
  Coverage   49.61%   49.61%           
=======================================
  Files          83       83           
  Lines       10692    10692           
=======================================
  Hits         5305     5305           
  Misses       5387     5387           
Flag Coverage Δ
tests 49.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nanasess nanasess enabled auto-merge March 13, 2025 04:33
@nanasess nanasess added this to the 2.25 milestone Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant