This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Update eos rodeos key_value.hpp and abieos module based on CDT 📦 #10889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the associated abieos PR? |
|
See EOSIO/abieos#139 |
huangminghuang
suggested changes
Nov 24, 2021
Comment on lines
758
to
759
| int32_t itr_stat = static_cast<typename iterator::status>(tbl->environment.kv_it_prev(itr, &found_key_size, &found_value_size)); | ||
| return {itr, static_cast<typename iterator::status>(itr_stat), this}; |
There was a problem hiding this comment.
you don't need to do the same static_cast twice.
| public: | ||
| enum class status { | ||
| iterator_ok = 0, // Iterator is positioned at a key-value pair | ||
| iterator_erased = -1, // The key-value pair that the iterator used to be positioned at was erased | ||
| iterator_end = -2, // Iterator is out-of-bounds | ||
| }; | ||
|
|
||
| iterator() = default; | ||
| iterator_base() = default; |
There was a problem hiding this comment.
I would prefer to have itr == 0 && itr_stat == iterator_endas a class invariant; i.e. whenever, you set itr to 0, also set itr_stat to iterator_end. This will simplify a lot of the compare code.
heifner
changed the title
huangminghuang
approved these changes
Dec 10, 2021
12 tasks
|
This PR is obsolete, see #11004 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR is an add-on for previous #10864, here the change in abieos submodule is included in this PR.
eos rodeos key_value.hpp at [develop-boxed] is behind CDT version at [develop-boxed], and that key_value.hpp in CDT libraries/eosiolib/contracts/eosio/ was renamed as table.hpp in EOSIO/eosio.cdt#996 last November, so now CDT [master] and CDT [develop] does NOT have key_value.hpp any more.
Here the proposed code change is based on the latest table.hpp in CDT [develop] branch.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions