This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Fix late transactions #4905
Merged
Fix late transactions #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er in node and reporting node status in shutdown. GH EOSIO#4903
heifner
approved these changes
Jul 27, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4903
In most cases the transaction has made it into a block and been processed by the history plugin before the python script calls getTransaction on the node, but it can fail sometimes, particularly when transaction is sent to one node and then getTransaction called on another node.
Added a flag to make a second pass if the first attempt to retrieve the transaction fails and some other extras, like reporting cluster status on failed test.