This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Add error output when ABI is not generated using "eosio-cpp" #1037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When using
eosio-cpp
to generate WASM and ABI, if the contract is empty, or if the specified contract name doesn't match the real contract name, the ABI will silently not be generated. This fix adds warning output, or throws exception with error messages, for this situation.Notes:
--abigen
option is set, the warning or error is output. This is to avoid incompatibility with some previous code (e.g. some contracts in the unit test code have different names for contract and filename). This decision can be further discussed.specified
contract name is either explicitly specified by--contract
, or inferred from output name by-o
, or the same as the contract filename if neither '--contract' or '-o' is set.API Changes
Documentation Additions