This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Removes the timestamp part of the abigen comment #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The abigen adds a comment to the generated ABI file. This comment includes a timestamp information at which time the ABI file was generated. This is problematic when trying to reproduce an exact identical ABI file since the timestamp will make the file looks different. This PR removes the actual timestamp information from the comment and only keep the static text instead. By not having the timestamp, someone can checkout a particular tag, perform the build step and validate that the sha256 of the ABI file has not changed.
larryk85
approved these changes
Jan 31, 2019
rise-worlds
pushed a commit
to potato-coin/eosio.cdt
that referenced
this pull request
Jul 14, 2020
…ment-timestamp Removes the timestamp part of the abigen comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The abigen adds a comment to the generated ABI file. This comment includes a timestamp information at which time the ABI file was generated. This is problematic when trying to reproduce an exact identical ABI file since the timestamp will make the file looks different.
This PR removes the actual timestamp information from the comment and only keep the static text instead.
By not having the timestamp, someone can checkout a particular tag, perform the build step and validate that the sha256 of the ABI file has not changed.