-
Notifications
You must be signed in to change notification settings - Fork 289
Conversation
`name_tests`, `symbol_tests`, `asset_tests`, `system_tests`, and `crypto_tests` now ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asset_tests.cpp
has warnings about unused comparisons. at lines 326, 519, 524 and 529. These are not doing anything, please change these to CHECK_EQUAL. Also the CHECK_PRINTs at line 424-436 are not correct and the check is failing. Also, where you are checking the string or print for a negative asset, you are using "--". This is a bug, please look at PR #422 and copy his fix over and fix these tests. You will not be able to simply merge his PR as it will overwrite too many things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
`eosiolib` Unit/Regression Tests Pipeline is shot, so merging in without full tests.
In correspondence with issue #376 unit/regression tests have been implemented for the following files:
asset.hpp
binary_extension.hpp
crypto.hpp
datastream.hpp
fixed_bytes.hpp
name.hpp
serialize.hpp
symbol.hpp
system.hpp
time.hpp
varint.hpp
This will ensure that the integrity of the data structures and their respective methods in directory
eosio.cdt/libraries/eosiolib/
will remain steadfast and consistent throughout any change that might happen to the library in the future.To run the tests simply enter the build directory (where my generated build directory is
eosio.cdt/build/
) and run thectest
command.For example:
~/eosio.cdt/build$ ctest