This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Add integration tests to CI #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linhuang-blockone
approved these changes
Sep 3, 2020
| @@ -292,7 +292,7 @@ steps: | |||
| agents: | |||
| queue: "automation-eks-eos-tester-fleet" | |||
| timeout: ${TIMEOUT:-10} | |||
| skip: ${SKIP_UBUNTU_18}${SKIP_UNIT_TESTS} | |||
| skip: ${SKIP_UBUNTU_18}${SKIP_INTEGRATION_TESTS} | |||
There was a problem hiding this comment.
Why is integration test to be skipped?
There was a problem hiding this comment.
This flag gives you the option to skip the tests by setting an ENV var on a specific build. This is really useful when debugging a different part of the CI pipeline.
There was a problem hiding this comment.
Thanks for your explanation! Didn't realize it is a flag.
scottarnette
approved these changes
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Depends on #965 to pass integration tests
API Changes
Documentation Additions