This repository was archived by the owner on Aug 2, 2022. It is now read-only.
add an example for kv test #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimjh2005
reviewed
Oct 16, 2020
examples/kv_tests/src/kvtest.cpp
Outdated
| require_auth(_self); | ||
| kvtest_table table{"kvtest"_n}; | ||
|
|
||
| uint64_t id = 1; |
There was a problem hiding this comment.
Please check tab character here and below.
kimjh2005
reviewed
Oct 16, 2020
examples/kv_tests/src/kvtest.cpp
Outdated
| auto itr = table.id.find(id); | ||
| if (itr != table.id.end()) { | ||
| std::string val = itr.value().data; | ||
| eosio::check(val.compare(data + std::to_string(id)), "The value for the key " + std::to_string(id) + " is " + val); |
There was a problem hiding this comment.
val can be 8MB string too big to print.
kimjh2005
reviewed
Oct 16, 2020
examples/kv_tests/README.txt
Outdated
| @@ -0,0 +1,16 @@ | |||
| --- kv_addr_book Project --- | |||
kimjh2005
reviewed
Oct 16, 2020
examples/kv_tests/src/kvtest.cpp
Outdated
| @@ -0,0 +1,60 @@ | |||
| #include <eosio/eosio.hpp> | |||
| #include <eosio/asset.hpp> | |||
There was a problem hiding this comment.
Do you have to include this?
There was a problem hiding this comment.
Yes. I used eosio::check in the code.
kimjh2005
approved these changes
Oct 16, 2020
|
A couple of observations:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
API Changes
Documentation Additions