Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

abigenerator bug fix #989

Merged
merged 7 commits into from
Nov 10, 2020
Merged

abigenerator bug fix #989

merged 7 commits into from
Nov 10, 2020

Conversation

vzqzhang
Copy link
Contributor

@vzqzhang vzqzhang commented Nov 5, 2020

Change Description

Fix a bug that abigenerator fails to get the types of keys of KV tables when using namespaces in the types

Change Type

Select ONE

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Copy link
Contributor

@larryk85 larryk85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding the note here for posterity, we have already discussed this.

Please add toolchain tests that test this issue so that we won't regress in the future.

@vzqzhang
Copy link
Contributor Author

vzqzhang commented Nov 6, 2020

Just adding the note here for posterity, we have already discussed this.

Please add toolchain tests that test this issue so that we won't regress in the future.

Added a toolchain test

Copy link
Contributor

@larryk85 larryk85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait until everything is green before merging. Thanks again.

@vzqzhang vzqzhang merged commit cf5fb4b into develop Nov 10, 2020
@vzqzhang vzqzhang deleted the abigen_bug_fix branch November 10, 2020 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants