Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neon_sites_dompft.csv #1933

Merged
merged 7 commits into from
Feb 2, 2023
Merged

Update neon_sites_dompft.csv #1933

merged 7 commits into from
Feb 2, 2023

Conversation

wwieder
Copy link
Contributor

@wwieder wwieder commented Jan 11, 2023

Description of changes

incorrect lat-lon being used for ONAQ

Specific notes

Likely also need to update surface dataset and generate new initial conditions files.

Contributors other than yourself, if any:
@TeaganKing

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?

  • Yes, for NEON ONAQ sites

Any User Interface Changes (namelist or namelist defaults changes)?

  • Also need to check usermods

@wwieder wwieder added the bug something is working incorrectly label Jan 11, 2023
@TeaganKing
Copy link
Contributor

Thanks for making this change, @wwieder !

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jan 11, 2023
@wwieder
Copy link
Contributor Author

wwieder commented Jan 11, 2023

This PR also requires creating new surface data for ONAQ. For simplicity sake, I've made new surface datasets for all sites here /glade/scratch/wwieder/single_point_neon_updated/surfdata_1x1_NEON_*_hist_78pfts_CMIP6_simyr2000_c230111.nc

@ekluzek I'm assuming we're better off changing the default surface datasets in cime_config/usermods_dirs/NEON/defaults/user_nl_clm to point to these new surface data files, even though it's only ONAQ that's changed?

only needed for ONAQ, but done for all sites for consistency
@wwieder wwieder requested review from ekluzek January 11, 2023 14:54
@wwieder wwieder self-assigned this Jan 11, 2023
@wwieder
Copy link
Contributor Author

wwieder commented Jan 11, 2023

While we're mucking around I went ahead and looked at lat-lon coordinates for other NEON sites. I'm not sure of the history of the neon_sites_dompft.csv file, but comparing to the NEON_Field_Site_Metadata_20220412.csv file that's available from NEON. There are a few other differences at ORNL, UNDE, and BLAN that I'll go ahead and change here now.

@ekluzek ekluzek removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jan 12, 2023
@ekluzek
Copy link
Collaborator

ekluzek commented Jan 12, 2023

AT software meeting we decided @adrifoster will merge this into her #1932 and make the tag for this and hers together.

@ekluzek ekluzek merged commit c366a6a into master Feb 2, 2023
@ekluzek ekluzek deleted the wwieder-ONAQ_correction branch February 10, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants