Jgfouca/add code checking #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jedwards4b : Tests currently running, I'll let you know when they pass. |
| #!/usr/bin/env python | ||
|
|
||
| """ | ||
| Ensure that all CIME python files are free of errors |
There was a problem hiding this comment.
This is the new tool.
|
Annotations complete. |
|
Looks good to me, can you resolve conflicts and test again before merging? |
jgfouca
added a commit
that referenced
this pull request
Jul 19, 2016
Add a new tool that checks that all python library source files are 100% clean for a certain configuration of pylint. Fix all pylint errors discovered by the tool. Add a test to run this tool every night. Test suite: scripts_regression_tests Test baseline: Test namelist changes: Test status: bit for bit Fixes: [CIME Github issue #] User interface changes?: Code review: @jedwards4b * jgfouca/add_code_checking: Fix a couple remaining pylint issues Made code_checker parallel, fix test name so it actually runs Fix remaining test failures Bug fix All scripts passing Add code checker test. Remove refactor disablings from scripts_regression_tests.py Progress. Tool added. build.py 100% Conflicts: utils/python/CIME/case_setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new tool that checks that all python library source files are 100% clean for a certain configuration of pylint. Fix all pylint errors discovered by the tool. Add a test to run this tool every night.
Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes: [CIME Github issue #]
User interface changes?:
Code review: @jedwards4b