Add init files in package-like diagnostic directories to comply with pytest >=8.3.4
#3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouweandela
approved these changes
Dec 2, 2024
|
thanks, bud!! I thought you don't work on Mondays? But then again, I was getting commit emails last Saturday evening 😁 |
chrisbillowsMO
pushed a commit
that referenced
this pull request
Dec 4, 2024
…`pytest >=8.3.4` (#3834)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nightly tests are failing because our environment moved to use the latest
pytest==8.3.4since a day or so ago. This version complains about package-level imports from subdirs that are not package-like ie don't have at least an empty__init__.pyfile inside, and have scripts (modules) that bear the same name as the parent directory, see pytest-dev/pytest#12592 and release notes https://github.com/pytest-dev/pytest/releases - in fairness, I think this is a side-effect of that bug fix on the Pytest side, but a package-like structure is aqlways useful to have, since our imports are now package-level.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.