Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock screen bypass #28

Open
xopr opened this issue Aug 13, 2022 · 1 comment
Open

Lock screen bypass #28

xopr opened this issue Aug 13, 2022 · 1 comment

Comments

@xopr
Copy link

xopr commented Aug 13, 2022

tested on 0.8.30

Lock screen can be bypassed
STEPS TO REPRODUCE

  • enable screen lock and wait for the WiPhone to lock
  • press Hangup (WIPHONE_KEY_END)

CURRENT RESULT

  • device is unlocked

EXPECTED RESULT

  • device should stay locked

NOTE
Also note that the unlock procedure is a bit fiddly: when pressing Ok and accidentally pressing an arrow key, the sequence is reset: This can be fixed by ignoring the arrow keys in GUI.cpp on line 661 changing:

          if (state.unlockButton1) {

into:

          if (state.unlockButton1 && event != WIPHONE_KEY_UP & event != WIPHONE_KEY_DOWN && event != WIPHONE_KEY_LEFT && event != WIPHONE_KEY_RIGHT ) {
@xopr
Copy link
Author

xopr commented Aug 23, 2022

I think this patch should fix it, but I'm currently unable to test it; it might also break the clock's input.

hramrach pushed a commit to hramrach/wiphone-firmware that referenced this issue Jan 14, 2024
Lock screen can be bypassed

Enable screen lock and wait for the WiPhone to lock
Press Hangup (WIPHONE_KEY_END)
Before: device is unlocked
Expected: device should stay locked

Also the unlock procedure is a bit fiddly: when pressing Ok and
accidentally pressing an arrow key, the sequence is reset: This can be
fixed by ignoring the arrow keys in the first step of unlock.

Fixes: ESP32-WiPhone#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant