RTP stuff #1139
Merged
RTP stuff #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
carstene1ns
commented
Apr 3, 2017
carstene1ns
commented
- Add support for our RTP
- Supports multiple RTPs to be set from environment
- Adds official English 2k RTP names
Update manual page accordingly
Ghabry
reviewed
Apr 3, 2017
src/filefinder.cpp
Outdated
|
|
||
| // Windows paths are split by semicolon, Unix paths by colon | ||
| std::function<bool(char32_t)> f = [](char32_t t) { | ||
| return t == ';' || t == ':'; |
There was a problem hiding this comment.
This must be if-defed because Splitting at ":" will damage the path on Windows due to the drive letters being C:\
Ghabry
requested changes
Apr 4, 2017
|
|
||
| NOTE: All '*_RTP_PATH' variables support directory lists, using colon (':') or | ||
| semicolon (';') as separator. Useful when you have multiple translated RTP | ||
| versions or directories with extra files. |
There was a problem hiding this comment.
Remove "or semicolon(';')" because no manpage support unter Windows
|
Our manual page is not really limited by the platform, everthing documented there should work under Windows as well. We could even ship a html version with the |
fdelapena
approved these changes
Apr 4, 2017
|
Jenkins: Test this please |
Ghabry
approved these changes
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.