Resolve metainfo linter warnings #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
carstene1ns
force-pushed
the
fix/metainfo
branch
from
714cb5c to
5e7f975
Compare
|
This now also fixes the liblcf build. |
|
well I have no experience with flatpak so feel free to merge this when you consider it done. |
|
Just waiting to clear the nits found by flathub maintainers before amending here. |
carstene1ns
force-pushed
the
fix/metainfo
branch
from
5e7f975 to
3c3bd73
Compare
fdelapena
approved these changes
Apr 2, 2024
carstene1ns
added a commit
to flathub/org.easyrpg.player
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding 0.8 to flathub1 their linker gave 2 warnings:
"appstream-summary-too-long"2
"appstream-screenshot-missing-caption"3
This resolves both of them, but I am still unsure about the short[sic!] summary...
The now enabled URLs are untested, I just think this must be supported after 2 years. 🏂🏼
Footnotes
https://github.com/flathub/flathub/pull/5088 ↩
https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines/#not-too-long-1 ↩
https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#screenshots ↩