Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use expressive-code-twoslash plugin #943

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

lishaduck
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

effective-code-twoslash is a more featureful fork1 of the handrolled twoslash plugin included in the site.
The important part is that it has much nicer tooltips, where the types are syntax highlighted instead of all being purple.

Related

  • Related Issue #
  • Closes #

Footnotes

  1. I skimmed the code and it looked similar, and it listed the site as inspiration in the credits.

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-content ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 4:26pm
website-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 4:26pm
website-proxy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 4:26pm

Copy link

vercel bot commented Nov 25, 2024

@lishaduck is attempting to deploy a commit to the Effect Team on Vercel.

A member of the Team first needs to authorize it.

@IMax153
Copy link
Member

IMax153 commented Nov 25, 2024

@lishaduck - Wow! I had no idea someone took these ideas and ran with them like this! Deploying the site now and will take a look, thanks 👍

@gcanti
Copy link
Contributor

gcanti commented Nov 25, 2024

Nice!

/cc @Adammatthiesen

@IMax153
Copy link
Member

IMax153 commented Nov 25, 2024

Indeed! Super cool work @Adammatthiesen

@IMax153
Copy link
Member

IMax153 commented Nov 25, 2024

Thanks @lishaduck 👍

@IMax153 IMax153 merged commit 65faaf8 into Effect-TS:main Nov 25, 2024
4 checks passed
@lishaduck lishaduck deleted the expressive-code-twoslash branch November 25, 2024 17:05
@Adammatthiesen
Copy link

Indeed! Super cool work @Adammatthiesen

Awesome to see you guys using it... I've been working for quite a while trying to figure out some of the nitty-gritty with this system, and even including minified floating_ui for the fancy popups... been talking to the creator of Expressive-code about some of the functionality for awhile as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants