Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE Onion failures without a channel_update #6200

Open
TheBlueMatt opened this issue Apr 23, 2023 · 1 comment
Open

UPDATE Onion failures without a channel_update #6200

TheBlueMatt opened this issue Apr 23, 2023 · 1 comment

Comments

@TheBlueMatt
Copy link

I'm seeing some payment failures occasionally that come back with a full onion error of 10070000 (ie temporary_channel_failure with a channel_update len of 0). I've looked up a few of the nodes and those that have a node type tag on 1ml seem to say CLN. They might be an ancient version, no idea, one such node is https://1ml.com/node/020a1df50b701331a29782093210460b10eee0ac5ef6a01b9c51dff9b8fddf5fb0

I saw it testing some unique payments so it may be some bug on my end tickling CLN, dunno, but the spec seems to forbid this (Please note that the channel_update field is mandatory in messages whose failure_code includes the UPDATE flag).

@TheBlueMatt
Copy link
Author

Apparently that specific node is running 22.11.1.

valentinewallace added a commit to valentinewallace/rust-lightning that referenced this issue Sep 15, 2023
We've run into this several times in the wild, likely due to
ElementsProject/lightning#6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).

Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be so common and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
valentinewallace added a commit to valentinewallace/rust-lightning that referenced this issue Sep 15, 2023
We've run into this several times in the wild, likely due to
ElementsProject/lightning#6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).

Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be so common and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
valentinewallace added a commit to valentinewallace/rust-lightning that referenced this issue Sep 15, 2023
We've run into this several times in the wild, likely due to
ElementsProject/lightning#6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).

Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be recurring and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
valentinewallace added a commit to valentinewallace/rust-lightning that referenced this issue Sep 20, 2023
We've run into this several times in the wild, likely due to
ElementsProject/lightning#6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).

Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be recurring and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
valentinewallace added a commit to valentinewallace/rust-lightning that referenced this issue Sep 21, 2023
We've run into this several times in the wild, likely due to
ElementsProject/lightning#6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).

Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be recurring and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
valentinewallace added a commit to valentinewallace/rust-lightning that referenced this issue Sep 21, 2023
We've run into this several times in the wild, likely due to
ElementsProject/lightning#6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).

Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be recurring and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
valentinewallace added a commit to valentinewallace/rust-lightning that referenced this issue Sep 22, 2023
We've run into this several times in the wild, likely due to
ElementsProject/lightning#6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).

Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be recurring and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
dunxen pushed a commit to dunxen/rust-lightning that referenced this issue Sep 26, 2023
We've run into this several times in the wild, likely due to
ElementsProject/lightning#6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).

Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be recurring and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
slanesuke pushed a commit to slanesuke/rust-lightning that referenced this issue Oct 6, 2023
We've run into this several times in the wild, likely due to
ElementsProject/lightning#6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).

Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be recurring and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
optout21 pushed a commit to optout21/rust-lightning that referenced this issue Nov 4, 2023
We've run into this several times in the wild, likely due to
ElementsProject/lightning#6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).

Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be recurring and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant