Change typings #198
Closed
Change typings #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6utt3rfly
reviewed
Oct 31, 2021
| @@ -1,161 +1,173 @@ | |||
| declare module 'jsep' { | |||
|
|
|||
| namespace jsep { | |||
There was a problem hiding this comment.
Without the namespace can it still support the various ways that jsep is used?
import jsep from 'jsep'import * as jsep from 'jsep'const jsep = require('jsep')const { Jsep } = require('jsep')(this PR adds types for the class, which is great!)
| register: (...plugins: IPlugin[]) => void; | ||
| } | ||
|
|
||
| export class Jsep { |
There was a problem hiding this comment.
Good to add this class export for const { Jsep } = require('jsep') ... but can it be combined to support const jsep = require('jsep') and import jsep from 'jsep' and import * as jsep from jsep?
| public static removeLiteral(literalName: string): Jsep; | ||
| public static removeAllLiterals(): Jsep; | ||
|
|
||
| public get char(): string; |
There was a problem hiding this comment.
these getters are useful for the hooks (which is why they're defined in the HookScope), but not sure they need to be here for public use?
|
Closed as abandoned & stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy hacktoberfest! Was just passing by using this library in a project, but we found it useless for our needs. By while I was researching it, I found out that some types was not present. So I've added them!