feat(block, block-section): add expanded property and deprecate open property
#11582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elijbet
changed the title
expanded property and deprecate open property
Elijbet
changed the title
expanded property and deprecate open propertyexpanded property and deprecate open property
Elijbet
added
pr ready for visual snapshots
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
Stale
Elijbet
force-pushed
the
elijbet/11225-block-to-use-expanded-prop
branch
from
55fcf6c to
15a469d
Compare
Elijbet
added
pr ready for visual snapshots
jcfranco
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
🚀 Review comments from #11003 (review) are also applicable here. Good to merge afterwards!
| @@ -122,23 +122,23 @@ export const darkModeRTL_TestOnly = (): string => html` | |||
| <calcite-block | |||
| heading="Heading" | |||
| description="description" | |||
| open | |||
| expanded | |||
| collapsible | |||
There was a problem hiding this comment.
After seeing the renamed prop in context, I think we should deprecated collapsible in favor of expandable. We can tackle this separately to allow for some initial discussion.
There was a problem hiding this comment.
6 tasks
Elijbet
added
skip visual snapshots
benelan
added a commit
that referenced
this pull request
Mar 6, 2025
* origin/dev: (80 commits) build(deps): update nx monorepo to v20.4.6 (#11662) build(deps): update arcgis to ^4.32.7 (#11648) build: update browserslist db (#11639) build(deps): update eslint (#11670) build(deps): update dependency chromatic to v11.26.1 (#11669) build(deps): update dependency rollup to v4.34.9 (#11661) build(deps): update dependency tsx to v4.19.3 (#11658) chore: release next docs(text-area): update limitText description (#11672) feat(block, block-section): add `expanded` property and deprecate `open` property (#11582) feat(list-item, list): add `expanded` property and deprecate `open` property (#11003) chore: release next fix(tabs): redisplay close button when more than one tab is closable (#11492) test(shell-panel): Fix token story set up (#11635) chore: set up 3rd-party license generation (#11640) build(deps): update dependency happy-dom to v17.1.8 (#11649) build(deps): update dependency prettier to v3.5.2 (#11642) build(deps): update dependency happy-dom to v17.1.6 (#11641) chore: release next fix(card-group): Restore default gap spacing (#11638) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6473, #11225
Summary
Deprecate
openprop in favor ofexpanded. Add logger warning for deprecation to help inform users about the deprecated property and guide them towards using the recommended alternatives.