fix: patch esm resolution issue causing webpack build error #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
approved these changes
Aug 12, 2022
benelan
added a commit
that referenced
this pull request
Dec 14, 2023
**Related Issue:** #8421 ## Summary Ensure the build used for `next` releases includes patches. This fixes a regression caused by #8325, where we removed the extra build on prepublish. The extra build was fixing some issues caused by `npm run test:prerender`, where a build occurred that didn't run pre/post build scripts, including the ESM resolution patch added in #5145.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5141
Summary
Patches an ES module resolution error caused by adding
type="module"in ourpackage.json. I confirmed it works usingnpm linkw/ our webpack example.