Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

1.2.0 #21

Merged
merged 3 commits into from
Aug 30, 2018
Merged

1.2.0 #21

merged 3 commits into from
Aug 30, 2018

Conversation

SkyeSeitz
Copy link
Contributor

Added to GIS

• hillshade-effect
• compass-needle

screen shot 2018-08-29 at 4 42 31 pm


Added to Generic
• transparency

screen shot 2018-08-29 at 4 43 04 pm


Added to Text
•gamma

screen shot 2018-08-29 at 4 42 18 pm


This branch resolves issue #18

@griffgriffindor
Copy link
Contributor

Looks good!

@griffgriffindor
Copy link
Contributor

@asangma @julio8a Because we also have compass-north-circle, we need to create a pattern which establishes which compass to use in certain circumstances… sometimes compass-north-circle is better, other times compass-needle will be better.

@asangma
Copy link

asangma commented Aug 30, 2018

we need to create a pattern which establishes which compass to use in certain circumstances

Agreed.
Feel free to spin up an issue/discussion. We can probably extract a fair bit from current usage.

@asangma
Copy link

asangma commented Aug 30, 2018

@johnmgriffith I did not see a compass-needle-[size]-f.svg. Is that in the works?

@griffgriffindor
Copy link
Contributor

Julio said that unless there is a structural or process change, it's unnecessary to add him as a reviewer. We should be good to merge and release now.

@griffgriffindor
Copy link
Contributor

@asangma yes, under Files Changed tab, we've got the compass-needle-32-f and other sizes there. The top part of the needle is filled in on those assets.

@asangma
Copy link

asangma commented Aug 30, 2018

Got it. Sorry...must have missed it. 👍

@SkyeSeitz SkyeSeitz merged commit 767c8ed into master Aug 30, 2018
@SkyeSeitz SkyeSeitz deleted the 1.2.0 branch August 30, 2018 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants