[$250] [Due for payment 2025-02-27] Search - Last digits are cleared when trying to enter a second decimal point (dot)

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #53695
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: MacOS Chrome, Desktop
App Component: Search

Action Performed:

1. Go Reports > click on Filter > click on Total
2. Enter few digits > press dot key or comma key to enter a decimal point
3. Enter two digits after the decimal point
4. Move the cell pointer on the left side of the entered decimal point (dot)
5. Press dot key

Expected Result:

Nothing should happen as there is an existing decimal point (dot) in the number
Or pointer should jump to the end of entered amount as it does on production

Actual Result:

The last digits next to first decimal point are cleared

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6733024_1738666256330.Screen_Recording_2025-02-04_at_1.43.56_in_the_afternoon.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895250081726909105
• Upwork Job ID: 1895250081726909105
• Last Price Increase: 2025-02-27

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Not repro on prod

bandicam.2025-02-04.13-57-52-985.mp4

[brunovjk]

@kirillzyusko do you know what might be causing this too? I'll look into it in a moment.

[kirillzyusko]

Looking into this 👀

[kirillzyusko]

I think I found a fix - will try to prepare PR tomorrow!

[luacmartins]

Thanks @kirillzyusko! This is a deploy blocker, so we'll try to address it today. Do you know the cause of the issue?

[luacmartins]

Demoting it to NAB. @kirillzyusko let's address this tomorrow

[kirillzyusko]

Do you know the cause of the issue?

Well, yeah, a new input implementation 😁

And now the algorithm works like:

• we have an input 123,456
• let's try to format it to mask, so the value will be 123,45
• let's apply the mask

My current approach is to create a variations of the mask (affine format) so that 123,456 will be considered as invalid input for mask and such change will be simply ignored.

Thanks for demoting this!

[kirillzyusko]

Okay, the trick with affinity format didn't work, so currently I'm working on another solution.

The new approach will be the validation of a new string before proceeding to "masking" stage. I think tomorrow I can prepare a PR and will ask @brunovjk to test these changes (because he has a lot of knowledge on how to test this component) 👀

[melvin-bot]

@alexpensify, @luacmartins, @kirillzyusko, @brunovjk Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: pre-validate masked input #56462

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

• @kirillzyusko does not require payment (Contractor)
• @brunovjk requires payment (Needs manual offer from BZ)

[melvin-bot]

@brunovjk @alexpensify @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[brunovjk]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: This is a follow-up issue.
  Coming from: Create amount filter #47343 (comment) and Create amount filter #47343 (comment)

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other: Coming from: Create amount filter #47343 (comment)

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: It is connected to these issues: Can't prevent default input in TextInput in controlled component facebook/react-native#38155, TextInput flickering when format the text facebook/react-native#24585, and how the native TextInput component works.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

Steps to Test:

1. Go Reports > click on Filter
2. In the Greater than/Less than fields:
   • Enter a few digits.
   • Press dot (.) or comma (,) to enter a decimal point.
   • Enter two digits after the decimal point.
3. Try entering more symbols after the two decimal places:
   • Ensure additional characters do not get entered and are instantly removed.
4. Move the cursor to the left of the decimal point.
5. Press dot (.) again and observe the behavior.

Do we agree 👍 or 👎

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @kirillzyusko is from an agency-contributor and not due payment
• ROLE: @brunovjk paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021895250081726909105

[melvin-bot]

Current assignee @brunovjk is eligible for the External assigner, not assigning anyone new.

[alexpensify]

Contributor: @kirillzyusko is from an agency-contributor and not due payment
Contributor+: @brunovjk $500 paid via Upwork

[brunovjk]

@alexpensify I think the value is not right. The original issue bounty was $500. Or does this count as a regression @luacmartins ? Thanks.

[luacmartins]

This was a tricky one, I think we can leave the original bounty of $500

[brunovjk]

Thank you @luacmartins.

Job added to Upwork: https://www.upwork.com/jobs/~021895250081726909105

@alexpensify can I accept this offer or do you need to create a new one? Thanks.

[alexpensify]

@brunovjk—Sorry for the confusion. There was no mention in the GH that this bounty should be $500. Thank you, @luacmartins, for confirming. I updated the payment details in Upwork. @brunovjk, please accept when you get a chance. The bounty should be correct now.

[brunovjk]

You're right, I should have mentioned this earlier, but its all good :D I accepted the offer, thanks a lot @alexpensify.

[alexpensify]

Done! I've completed the payment process - #56330 (comment)

@brunovjk, there was an issue in Upwork, and I gave the remaining amount that's due via a bonus. The final total was $500.