Incompatibility with newer version of SRT #17
Comments
amunhoz
changed the title
|
Yes, I think this is what issues #16 & #15 are also about! :) Thanks for the more clear and concise report here on this. Unfortunately haven't looked into this codebase for a bit, and we didn't have to deal with this issue in our prod case. @amunhoz You can deal with the current way to just modify the used libSRT git tag in the build script? What do you suggest? |
This was referenced Mar 3, 2021
Closed
tchakabam
added a commit
to emliri/node-srt
that referenced
this issue
Mar 23, 2021
…accept call, but SRT v1.4.2 is checking for this size to be large enough to write into it the actual address in the first place. anyhow, wether we read it or not, it doesn't matter, the allocated size of sockaddr_in is always the same (per any platform).
|
@amunhoz There is a fix ^ |
birme
pushed a commit
that referenced
this issue
Mar 23, 2021
… resolve deprecation warning (use srt_create_socket instead srt_socket) (#21) * fixes #17: we set this 0 since not using their_addr output by accept call, but SRT v1.4.2 is checking for this size to be large enough to write into it the actual address in the first place. anyhow, wether we read it or not, it doesn't matter, the allocated size of sockaddr_in is always the same (per any platform). * fix deprecation warning on usage of srt_socket, replaced by srt_create_socket + fix newline-chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like the latest version of SRT is creating a problem with srt_accept, throwing a "bad parameter" error.
Did a test with a new build with the release zip of v1.4.1 and the problem disappeared.
Tested with Ubuntu 18.04 + Nodejs v14
The text was updated successfully, but these errors were encountered: