Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add addCustomDomains type definition #524

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amowu
Copy link

@amowu amowu commented Mar 7, 2025

Add missing type definition for the addCustomDomains method in Mailchecker. This improves type safety and ensures that users can benefit from full autocomplete support when using custom domains.

Add missing type definition for the addCustomDomains method in Mailchecker.
This improves type safety and ensures that users can benefit from full
autocomplete support when using custom domains.
Copy link
Collaborator

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but I'll wait for the @FGRibreau review before the merge.

@FGRibreau FGRibreau requested a review from Copilot March 12, 2025 20:36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants