Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fd 869 add status check to api #698

Conversation

ThomasMeier
Copy link
Contributor

This arises from a discussion with Anton, Jay, Matt, and I about a status endpoint. This arises from discussion about #671 in which the solution is to create a standalone, separate program to determine readiness from facts about the server. This PR is to propose adding a GET /status endpoint to the node with a variety of information the user can find for determining readiness. This helps satisfy some elements that the open api project and other projects want to use, in particular:

  1. A GET route to return 200. For now this is good enough singular point for checking liveness.
  2. Returns a collection of information to give insight to the user about readiness.

This is based on a sketch so let me know if this needs to go to a different branch or get rebased or moved to a different path, etc., the relevant code is under wsapi/wsapi.go

@stackdump stackdump changed the base branch from master to FD-869_add_status_check_to_api April 22, 2019 15:33
@stackdump
Copy link
Contributor

TODO:

  1. add docs about what each flag means
  2. add db syncing flag
  3. Ignore mode flag

@stackdump stackdump merged commit 9665d4c into FactomProject:FD-869_add_status_check_to_api Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants