Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppressed tests are not excluded for smart shardinig #984

Closed
kozaxinan opened this issue Aug 12, 2020 · 0 comments · Fixed by #990
Closed

Suppressed tests are not excluded for smart shardinig #984

kozaxinan opened this issue Aug 12, 2020 · 0 comments · Fixed by #990
Assignees
@piotradamczyk5
Labels
Bug Tiger 🐯

Comments

@kozaxinan
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.

androidx.test.filters.Suppress is an annotation from AndroidX library. Currently suppressed tests puts in a shard, and because it is suppressed, shard ends up with no test and looks like fail.

To Reproduce

Steps to reproduce the behavior:

  1. Run have and Suppress annotated test with smart sharding.
  2. See empty shard

Expected behavior

A clear and concise description of what you expected to happen.

Suppressed test can go into already existed shards
or
have similar handling like ignore annotation.

Details (please complete the following information):

Have you tested on the latest Flank snapshot?

Post the output of flank --version.

Flank 20.08.1
no orchestrator
4 additional apks
no video or performance
@kozaxinan kozaxinan added the Bug label Aug 12, 2020
@piotradamczyk5 piotradamczyk5 self-assigned this Aug 12, 2020
piotradamczyk5 pushed a commit that referenced this issue Aug 12, 2020
#984 Added @Suppress test as ignored
4d5292f
@piotradamczyk5 piotradamczyk5 mentioned this issue Aug 12, 2020
Merged
3 tasks
piotradamczyk5 pushed a commit that referenced this issue Aug 13, 2020
#984 Added @Suppress test as ignored
e0df8ff
piotradamczyk5 added a commit that referenced this issue Aug 13, 2020
@piotradamczyk5
fix: exclusion of @Suppress test (#990)
f6007e5 
* #984 Added @Suppress test as ignored

* Update release notes

* Fix tests
@kozaxinan kozaxinan mentioned this issue Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotradamczyk5 piotradamczyk5

Labels
Bug Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exclusion of @Suppress test Flank/flank
3 participants
@bootstraponline @kozaxinan @piotradamczyk5