Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup & remove some deps #1560

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Cleanup & remove some deps #1560

merged 1 commit into from
Mar 6, 2025

Conversation

pxl-th
Copy link
Member

@pxl-th pxl-th commented Mar 6, 2025

  • Get rid of Requires.
  • Remove GPUArrays dep as it is not used anywhere.
  • Move Atom to extension.
  • Minor cleanups after dropping 1.6 support.
  • Remove Zygote.refresh() as it seems it is no longer required (closes Seems to be #265ing #22):
julia> using Zygote

julia> g(x) = 2x;

julia> @show g'(10);
(g')(10) = 2.0

julia> g(x) = 3x;

julia> @show g'(10);
(g')(10) = 3.0

@pxl-th pxl-th requested a review from mcabbott March 6, 2025 17:43
@pxl-th pxl-th self-assigned this Mar 6, 2025
@pxl-th pxl-th requested a review from ToucheSir March 6, 2025 20:23
Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1272 is why the GPUArrays compat bound was put in place. As long is the downgrade issue there is no longer a problem, I think we can remove it. Otherwise this LGTM.

@pxl-th
Copy link
Member Author

pxl-th commented Mar 6, 2025

#1272 is why the GPUArrays compat bound was put in place. As long is the downgrade issue there is no longer a problem, I think we can remove it. Otherwise this LGTM.

Shouldn't be a problem. All GPU backends now use [email protected] and that itself will require newer GPUArrays package.

@pxl-th pxl-th merged commit c0bfc26 into master Mar 6, 2025
11 of 13 checks passed
@pxl-th pxl-th deleted the pxl-th/cleanup branch March 6, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems to be #265ing
2 participants