Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort folders by count #420

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Conversation

terofeev
Copy link
Contributor

@terofeev terofeev commented Mar 9, 2025

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added a new radio button to the sorting dialog for sorting folders by count.
  • Updated getDirectorySortingValue and getSortedDirectories functions to support sorting by count.

Before/After Screenshots/Screen Record

  • Before:
Before.mp4
  • After:
After.mp4

Fixes the following issue(s)

Relies on the following changes

Acknowledgement

@naveensingh naveensingh self-assigned this Mar 9, 2025
@naveensingh
Copy link
Member

I'm waiting for a new release on JitPack (link). Once the update is available, I will remove the temporary changes.

org.fossify.commons:9e28c573e8 is up now, thanks!

Remove temp code.
@terofeev
Copy link
Contributor Author

Thanks, @naveensingh! I've removed the temporary changes as mentioned. Could you please review this PR when you have time?

Fixed jitpack build.
@naveensingh
Copy link
Member

Looks good, thanks!

@naveensingh naveensingh merged commit f3b3eda into FossifyOrg:master Mar 11, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort folders by items quantity
2 participants