Fix missing .json file extension when exporting notes #14
Conversation
|
It works fine on Android 6, 13 and 14 (emulator). |
|
Thanks. I tried digging through the Android code to make sense of the automatic extensions but couldn't crack it. However I did find this which mentions
Duplicate names are interesting. I tested what happens on Android 9 when the file already exists (with this PR applied):
I can't test what happens on newer Android versions, but if this PR breaks the location of the "(1)" then I guess we'll have to add a check -- hopefully a simple Android version check will tell us whether .json will be appended automatically; if not, I'm not sure what to do. |
The input from the user doesn't have a .json suffix. Previously, we passed that value to ActivityResultContracts.CreateDocument as is (without an extension), and relied on the file picker to automatically append the extension based on the MIME type. But some file pickers don't automatically append the extension, e.g. the native Files app (com.android.documentsui) on Android <= 9, and FossifyOrg/File-Manager. This results in the exported file not having a .json extension. Fix this by manually appending the .json extension before passing the file name to CreateDocument. Manually appending the extension shouldn't cause a problem for file pickers that can automatically add an extension. For example the native Files app doesn't add a second extension, and if the file already exists it generates a unique name correctly, with the "(1)" inserted before the extension, e.g. "Notes (1).json". Fixes FossifyOrg#13.
tom93
force-pushed
the
fix-export-missing-file-extension
branch
from
c5a27ee to
433a7c1
Compare
|
I did more testing (see conclusions) and this PR does not cause issues when using the native Files app on Android 9, 10, 14 (including when the file already exists). If people want to test other file managers please do, otherwise I think this PR is ready to merge. |
Very similar to FossifyOrg/Notes#14 (which has a more detailed commit message). Basically, some file pickers don't automatically append the extension, so we should do it ourselves. It doesn't cause problems. Reported in FossifyOrg#88.
Very similar to FossifyOrg/Notes#14 (which has a more detailed commit message). Basically, some file pickers don't automatically append the extension, so we should do it ourselves. It doesn't cause problems. Reported in FossifyOrg#88.
|
I'll trust you guys on this one, thanks :) |
Very similar to FossifyOrg/Notes#14 (which has a more detailed commit message). Basically, some file pickers don't automatically append the extension, so we should do it ourselves. It doesn't cause problems. Reported in FossifyOrg#88.
Very similar to FossifyOrg/Notes#14 (which has a more detailed commit message). Basically, some file pickers don't automatically append the extension, so we should do it ourselves. It doesn't cause problems.
This is a fix for #13.
Update: #13 (comment) caught me by surprise, need to test that this works properly on more devices (don't want to end up with .json.json as the file extension), so I'm marking as Draft for now. Should also update the commit message to mention that this fix is only required in some circumstances (Android < 10?).
Update 2: Done (tested and updated commit message).