Content Security Policy #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriiNazimov
requested changes
Feb 12, 2023
There was a problem hiding this comment.
Есть небольшие замечания. В основном они касаются того, что я туповат, и мне нужны пояснения в виде комментариев в коде. Ну и @ts-ignore желательно убрать.
sdelfi
approved these changes
Feb 14, 2023
DmitriiNazimov
approved these changes
Feb 14, 2023
Olegas
reviewed
Feb 17, 2023
packages/server/routes/SSR.ts
Outdated
| @@ -104,7 +104,9 @@ export const SSRRoute = ({ vite, srcPath, distPath }: SSRRouteParams): RequestHa | |||
| ${helmet.meta.toString()} | |||
| ${helmet.link.toString()} | |||
| ` | |||
| ); | |||
| ) | |||
| .replace(`{csp.nonce}`, req.nonce) | |||
There was a problem hiding this comment.
А кто и куда вставляет такую строку?
There was a problem hiding this comment.
Изначально эта строка должна была заменять плейсхолдер в html на реальное значение nonce. Но я видимо не сохранил изменения в html 🤷.
Поменял метод на replaceAll.
* change lib option for es2021
…/FrontHeads/tanchiki into task/119-content-security-policy
Olegas
reviewed
Feb 17, 2023
|
|
||
| function applyNonce(req: Request, cspString: string): string { | ||
| if (cspString.includes(NONCE)) { | ||
| req.nonce = crypto.randomBytes(16).toString('base64'); |
There was a problem hiding this comment.
Синхронная версия randomBytes может заблокироваться в ожидании случайных данных. На веб-сервере лучше использовать асинхронную версию.
nodejs/help#457
Не призываю сейчас чинить, скорее на будущее
Olegas
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Настройка CSP.