Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/web 224/profile pic uploader #332

Merged

Conversation

Pero-Moretti
Copy link
Contributor

@Pero-Moretti Pero-Moretti commented Jul 10, 2021

Now de-linted and resolved initial PR comments.

Copy link
Member

@UncleClapton UncleClapton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the biggest things that stand out to me. I'm going to hold off on fine-tooth combing it until after you've linted and cleaned up your code.

Take your time, there's no rush on this 😄

@Pero-Moretti
Copy link
Contributor Author

I've fixed the comments and delinted. Only one thing I'm not 100% happy about, which is a render glitch on profile page load. Very briefly shows you the upload button. See what you think.

Copy link
Member

@UncleClapton UncleClapton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty good stuff. For the future, I would recommend looking into integrating ESLint and StyleLint into your IDE/Editor. You'll get real-time feedback and often times automatic fixes / suggestions. There's extensions for each on most modern code editors.

I'm still looking into that CSS issue with the modal opener button. I'll let you know when I find out why. If it's simple enough I'll just apply the fix along with the merge to develop.

@UncleClapton
Copy link
Member

@Pero-Moretti Just those couple things there about your image processing code and I think we're all good.

@UncleClapton
Copy link
Member

Just leaving this note here. I'm going to merge this PR once the final change is in. Any further changes/fixes (mainly that graphical bug) should be made in a follow-up

@Pero-Moretti
Copy link
Contributor Author

All done.

@UncleClapton
Copy link
Member

It works, but not in the way the user expects.

Yeah probably best to forbid it just for the sake of leaving them with the expectation that animated images are not supported.

Copy link
Member

@UncleClapton UncleClapton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UncleClapton UncleClapton merged commit 6498d28 into FuelRats:develop Jul 16, 2021
@UncleClapton UncleClapton mentioned this pull request Oct 17, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants