Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#355 fix Avatar uploader jank #375

Merged
merged 22 commits into from
Sep 13, 2021
Merged

Conversation

UncleClapton
Copy link
Member

Closes #355

Changelog

✨ Additions

  • Added styling to sliders
  • Added an extended slider component that adds an optional icon to the slider handle

⚡ Changes

  • Avatar uploader now have slider marks for both zoom and rotation
  • Avatar uploader will now only show the uploader and crop tool independently
  • Avatars now detect API avatars correctly

🐛 Fixes

  • Security headers for safari have been fixed (A bug introduced upon adopting next-safe)

Additional Information

Contributor's Checklist

  • This PR was created to resolve an existing issue or set of issues.
  • This PR satisfies any and all acceptance criteria laid out by issue(s) it resolves.
  • I have discussed creating this PR with the maintainers in the issue(s) beforehand.
  • I have thoroughly tested the changes this PR introduces in a local development environment.
  • I have linted the entire codebase using yarn lint and confirmed there are no errors or warnings.
  • I have followed the commit conventions laid out by CONTRIBUTING.md.

Maintainer's Checklist

  • User-facing changes this PR introduces has been or will be documented in CHANGELOG.md.
  • This PR has been linted and tested locally as a part of the review process.
  • All issues this PR resolves have been properly linked before merging.

…l on a flag prop

This also fixes page load pop-in issues
@UncleClapton UncleClapton changed the title Fix/avatar uploader jank #355 fix Avatar uploader jank Sep 13, 2021
@UncleClapton UncleClapton self-assigned this Sep 13, 2021
@UncleClapton UncleClapton added Type | Bug 🐛 An issue or PR that describes or fixes a problem with existing code Type | Enhancement ⚡ A PR that enhances an existing feature. labels Sep 13, 2021
@UncleClapton UncleClapton merged commit aa6e9f7 into develop Sep 13, 2021
@UncleClapton UncleClapton deleted the fix/avatar-uploader-jank branch September 13, 2021 03:20
@UncleClapton UncleClapton mentioned this pull request Oct 17, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type | Bug 🐛 An issue or PR that describes or fixes a problem with existing code Type | Enhancement ⚡ A PR that enhances an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar Uploader Improvements
1 participant