Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash Report: Null Object Reference when exiting the Input Offset menu #3489

Closed
2 tasks done
MTB207 opened this issue Sep 30, 2024 · 3 comments · Fixed by #3493
Closed
2 tasks done

Crash Report: Null Object Reference when exiting the Input Offset menu #3489

MTB207 opened this issue Sep 30, 2024 · 3 comments · Fixed by #3493
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Milestone

Comments

@MTB207
Copy link

MTB207 commented Sep 30, 2024

Issue Checklist

  • I have properly named the issue
  • I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.5.1

Context (Provide screenshots or videos of the crash happening)

im not entirely sure how this happened but after downloading the new version and trying to finally fc cocoa erect i noticed that my game wasnt running smoothly as it should so i went to settings where my fps was reseted to 60. music cut off once i got on the options menu and after kicking my frames up and entering the input offset screen for no real reason i got a null object as soon as i tried to exit

Steps to reproduce

not sure how to replicate this, maybe its a one time thing but still
PS it is not a one time thing

Crash logs (can be found in the logs folder where Funkin.exe is)

crash-2024-09-30-21-01-05.log
crash-2024-09-30-21-01-03.log

@MTB207 MTB207 added status: pending triage Awaiting review. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression labels Sep 30, 2024
@lemz1
Copy link
Contributor

lemz1 commented Sep 30, 2024

i looked at the code, and noticed that the crash happens because no music was playing
i'll just quickly make a pr for that

@lemz1
Copy link
Contributor

lemz1 commented Sep 30, 2024

btw i was able to replicate the issue, it seems as if going to freeplay and then back to mainmenu and then to options makes the music cut off, idk why though, definitely gotta look into that

@EliteMasterEric EliteMasterEric changed the title Crash Report: null reference when trying to exit the input offset Crash Report: Null Object Reference when exiting the Input Offset menu Oct 1, 2024
@EliteMasterEric EliteMasterEric self-assigned this Oct 1, 2024
@EliteMasterEric EliteMasterEric added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: pending triage Awaiting review. labels Oct 1, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.2 milestone Oct 1, 2024
@AbnormalPoof
Copy link
Collaborator

Fixed in v0.5.2.

@Hundrec Hundrec added status: resolved The issue has been fixed or the suggestion has been implemented. and removed status: pending pull request Dependent on a pull request that is currently awaiting review. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants