Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where LatencyState crashes when exiting #3493

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Fix an issue where LatencyState crashes when exiting #3493

merged 3 commits into from
Oct 1, 2024

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented Sep 30, 2024

FIXES

Fixes #3489

ADDITIONS

Adds an if check before setting music volume in LatencyState

@lemz1 lemz1 changed the base branch from main to develop September 30, 2024 22:35
@EliteMasterEric EliteMasterEric added status: pending triage Awaiting review. and removed status: pending triage Awaiting review. labels Oct 1, 2024
@EliteMasterEric EliteMasterEric self-assigned this Oct 1, 2024
@EliteMasterEric EliteMasterEric added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. labels Oct 1, 2024
@EliteMasterEric EliteMasterEric changed the title Fix LatencyState Fix an issue where LatencyState crashes when exiting Oct 1, 2024
@EliteMasterEric EliteMasterEric merged commit 7c7d052 into FunkinCrew:develop Oct 1, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.2 milestone Oct 1, 2024
@Hundrec Hundrec added the size: small A small pull request with 10 or fewer changes. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.

Crash Report: Null Object Reference when exiting the Input Offset menu
3 participants
@lemz1 @EliteMasterEric @Hundrec